Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18175 )
Change subject: IMPALA-11093: Fine grained table refreshing doesn't refresh table file metadata ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18175/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/18175/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2763 PS1, Line 2763: || hdfsPartition.getWriteId() <= partition.getWriteId())) { Please add a test for this since the bug was not caught in the existing test suite. http://gerrit.cloudera.org:8080/#/c/18175/1/fe/src/main/java/org/apache/impala/hive/common/MutableValidReaderWriteIdList.java File fe/src/main/java/org/apache/impala/hive/common/MutableValidReaderWriteIdList.java: http://gerrit.cloudera.org:8080/#/c/18175/1/fe/src/main/java/org/apache/impala/hive/common/MutableValidReaderWriteIdList.java@255 PS1, Line 255: updateMinOpenWriteId(); how is this related to this change? On a side note, can we always derive minOpenWriteId from exceptions list and abortedBits? If yes, we can skip maintaining minOpenWriteId -- To view, visit http://gerrit.cloudera.org:8080/18175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idabeb522525c45f000ca0992348660fa5a5d4d2d Gerrit-Change-Number: 18175 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Comment-Date: Fri, 28 Jan 2022 12:05:44 +0000 Gerrit-HasComments: Yes
