Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18175 )
Change subject: IMPALA-11093: Fine grained table refreshing doesn't refresh table file metadata ...................................................................... IMPALA-11093: Fine grained table refreshing doesn't refresh table file metadata If we insert data into an acid partitioned table from Hive, the generated events will be like open_txn -> alter_partition -> commit_txn. Previously we assumed the partition object with the alter_partition event has write id < current write id. However, that is not a valid assumption, the partition object is actually the write id allocated in this transaction. That means in commit_txn event, we will have a partition with write id equals to the write id of cached partition. So we need to modify the '<' condition to '<='. Tests: After IMPALA-10923, we now refresh file metadata while processing commit events. Therefore, we can add back the test disabled in IMPALA-9057. Change-Id: Idabeb522525c45f000ca0992348660fa5a5d4d2d Reviewed-on: http://gerrit.cloudera.org:8080/18175 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Sourabh Goyal <soura...@cloudera.com> Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> --- M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M tests/metadata/test_event_processing.py 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Impala Public Jenkins: Verified Sourabh Goyal: Looks good to me, but someone else must approve Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idabeb522525c45f000ca0992348660fa5a5d4d2d Gerrit-Change-Number: 18175 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Wen Lai <yu-wen....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sourabh Goyal <soura...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yu-Wen Lai <yu-wen....@cloudera.com>