Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17847 )
Change subject: IMPALA-10838: Error when struct returned from WITH() ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/17847/14/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/17847/14/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@268 PS14, Line 268: putStructMembersIntoSmap(slotDesc.getParent().getAlias(), smap_, (SlotRef) colExpr); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17847/14/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@269 PS14, Line 269: putStructMembersIntoSmap(slotDesc.getParent().getAlias(), baseTblSmap_, (SlotRef) colExpr); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17847/14/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@288 PS14, Line 288: private void putStructMembersIntoSmap(String aliasPrefix, ExprSubstitutionMap smap, SlotRef rhsStruct) { line too long (106 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iadb9233677355b85d424cc3f22b00b5a3bf61c57 Gerrit-Change-Number: 17847 Gerrit-PatchSet: 14 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 04 Feb 2022 15:06:25 +0000 Gerrit-HasComments: Yes
