Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 )
Change subject: IMPALA-11109: Catch class loading error for UDFs. ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG@9 PS3, Line 9: If a UDF fails to load, an exception needs to be caught I think we should mention that this fixes a regression and where it was introduced. For example, if the original commit is backported to some branch, if the regression is mentioned here we would know that this commit should also be backported. http://gerrit.cloudera.org:8080/#/c/18207/3//COMMIT_MSG@10 PS3, Line 10: logged Where do we log the exception? Don't we just re-throw it in HiveLegacyJavaFunction.java? http://gerrit.cloudera.org:8080/#/c/18207/3/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18207/3/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@170 PS3, Line 170: Throwable Can we be more specific about what kind of exceptions could be thrown? Or is it deliberately a catch-all clause? How does it help the catalogd if we re-throw the exception? -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Feb 2022 14:51:28 +0000 Gerrit-HasComments: Yes
