Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18207 )
Change subject: IMPALA-11109: Catch class loading error for UDFs. ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@167 PS5, Line 167: if (result.isEmpty()) { : throw new CatalogException("No compatible function signatures found."); : } > This looks a bit weird - the outer catch will catch the inner Catalog excep Done http://gerrit.cloudera.org:8080/#/c/18207/5/fe/src/main/java/org/apache/impala/hive/executor/HiveLegacyJavaFunction.java@170 PS5, Line 170: Throwable > Can you add a comment about why we check Throwable? Done -- To view, visit http://gerrit.cloudera.org:8080/18207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16813209cd4c2367c45e569c2aac13eff7ce2dbf Gerrit-Change-Number: 18207 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Wed, 09 Feb 2022 00:01:31 +0000 Gerrit-HasComments: Yes