Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17774 )
Change subject: IMPALA-10871: Add MetastoreShim to support Apache Hive 3.1.2 ...................................................................... Patch Set 13: (1 comment) Went through the Java code, looks great in general! http://gerrit.cloudera.org:8080/#/c/17774/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/17774/13/fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java@142 PS13, Line 142: private static final String EXTWRITE = "EXTWRITE"; Most parts seem to be the same as in https://github.com/apache/impala/blob/master/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java We could create a base class for the two with the shared constants and functions (e.g. org.apache.impala.catalog.Hive3MetastoreShimBase). This would highlight the parts that are actually different + make creating new Shims easier. -- To view, visit http://gerrit.cloudera.org:8080/17774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f08db5f6da735ac431819063060941f0941f606 Gerrit-Change-Number: 17774 Gerrit-PatchSet: 13 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Feb 2022 18:12:51 +0000 Gerrit-HasComments: Yes
