Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18234 )
Change subject: IMPALA-11008: fix incorrect to propagate inferred predicates ...................................................................... Patch Set 5: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/18234/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18234/5//COMMIT_MSG@30 PS5, Line 30: Could you summarize how the bug is fixed? http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@514 PS5, Line 514: : nit: remove ":" http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@514 PS5, Line 514: t2.id's slot id nit: the slot id of t2.id http://gerrit.cloudera.org:8080/#/c/18234/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@515 PS5, Line 515: ojEqualSlots nit: can we indicate 'nullable side' in the var name, e.g. ojNullableEqualSlots? Feel free to find a better name. -- To view, visit http://gerrit.cloudera.org:8080/18234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e64230f6d0c2b9ef1560186ceba349a5920ccdf Gerrit-Change-Number: 18234 Gerrit-PatchSet: 5 Gerrit-Owner: Xianqing He <hexianqing...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Wed, 23 Feb 2022 03:21:38 +0000 Gerrit-HasComments: Yes
