Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/18270 )
Change subject: IMPALA-11133 (Addendum): Encode a string in utf8 before printing it ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18270/1/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/18270/1/bin/compare_branches.py@271 PS1, Line 271: utf8 Nit: could you please use the same encoding alias at all the three locations on this line? I know they are all aliases (cf. https://docs.python.org/2/library/codecs.html#standard-encodings), but unifying them would save future readers the trip to that web page. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad9b1fb0a523e219bc9f40a57ff7335808be283f Gerrit-Change-Number: 18270 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 24 Feb 2022 16:04:34 +0000 Gerrit-HasComments: Yes
