Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18299 )

Change subject: IMPALA-11156: TestHmsIntegration.test_desc_json_table failed in 
exhaustive build
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18299/3/tests/metadata/test_hms_integration.py
File tests/metadata/test_hms_integration.py:

http://gerrit.cloudera.org:8080/#/c/18299/3/tests/metadata/test_hms_integration.py@108
PS3, Line 108:     """This function tests if JSON tables created
             :     in impala can be described in hive"""
nit: you don't need to wrap comments in such a small width..


http://gerrit.cloudera.org:8080/#/c/18299/3/tests/metadata/test_hms_integration.py@123
PS3, Line 123: """
nit: please use # instead.



--
To view, visit http://gerrit.cloudera.org:8080/18299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ddd983aeb82817eb355ca94dcf4a6875986f8e1
Gerrit-Change-Number: 18299
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Mar 2022 08:29:03 +0000
Gerrit-HasComments: Yes

Reply via email to