Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18370 )
Change subject: IMPALA-11213: Fixed impala-shell strict hs2 mode for large fetches ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18370/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18370/1//COMMIT_MSG@12 PS1, Line 12: > nit: add a sentence about what type of test has been added. Done http://gerrit.cloudera.org:8080/#/c/18370/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/18370/1/shell/impala_client.py@1126 PS1, Line 1126: tcol = col_value_converters[0][0](resp.results.columns[0]) > Is checking the number of columns the safest way ? Is there an alternative Yeah, this is the only way as far as I can tell. I looked at Hive Beeline implementation and they iterate through the columns. There is no field which provides the number of rows. The columns are the only place where we can find this information. -- To view, visit http://gerrit.cloudera.org:8080/18370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife436d91e7fe0c30bf020024e20a5d8ad89faa24 Gerrit-Change-Number: 18370 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Mar 2022 21:30:53 +0000 Gerrit-HasComments: Yes
