Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18295 to look at the new patch set (#4). Change subject: IMPALA-11162: Support GenericUDFs for Hive ...................................................................... IMPALA-11162: Support GenericUDFs for Hive Hive has 2 types of UDFs. This commit contains limited support for the second generation UDFs called GenericUDFs. The main limitations are as follows: Decimal types are not supported. The Impala framework determines the precision and scale of the decimal return type. However, the Hive GenericUDFs allow the capability to choose its own return type based on the parameters. Until this can be resolved, it is safer to forbid decimals from being used. Note that this limitation currently exists in the first generation of Hive Java UDFs. Complex types are not supported. Functions are not extracted from the jar file. The first generation of Hive UDFs allowed this because the method prototypes are explicitly defined and can be determined at funciton creation time. For GenericUDFs, the return types are determined based on the parameters passed in when running a query. For the same reason as above, GenericUDFs cannot be made permanent. They will need to be recreated everytime the server is restarted. This is a severe limitation and will be resolved in the near future. Change-Id: Ie6fd09120db413fade94410c83ebe8ff104013cd --- A fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java M fe/src/main/java/org/apache/impala/hive/executor/HiveJavaFunctionFactoryImpl.java A fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java M fe/src/main/java/org/apache/impala/hive/executor/UdfExecutor.java A fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java M fe/src/test/java/org/apache/impala/hive/executor/UdfExecutorTest.java A java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java A java/test-hive-udfs/src/main/java/org/apache/impala/GenericReplaceStringUdf.java A java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java A java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfException.java A testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test A testdata/workloads/functional-query/queries/QueryTest/load-generic-java-udfs.test M tests/query_test/test_udfs.py 13 files changed, 1,785 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/18295/4 -- To view, visit http://gerrit.cloudera.org:8080/18295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie6fd09120db413fade94410c83ebe8ff104013cd Gerrit-Change-Number: 18295 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>