Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18383 )

Change subject: IMPALA-11023: Raise error when delete file is found in an 
Iceberg table
......................................................................


Patch Set 1:

(1 comment)

Thanks for fixing this!

http://gerrit.cloudera.org:8080/#/c/18383/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java
File fe/src/main/java/org/apache/impala/util/IcebergUtil.java:

http://gerrit.cloudera.org:8080/#/c/18383/1/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@556
PS1, Line 556: fileScanTasks
Seems like we don't need this variable, the for-loop could just remain:

 for (FileScanTask task : scan.planFiles()) {



--
To view, visit http://gerrit.cloudera.org:8080/18383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e9cbf2424b27157883d551f73e728ab4ec6d21e
Gerrit-Change-Number: 18383
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tma...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Apr 2022 13:18:58 +0000
Gerrit-HasComments: Yes

Reply via email to