Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18383 )
Change subject: IMPALA-11023: Raise error when delete file is found in an Iceberg table ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/18383/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18383/4/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@122 PS4, Line 122: dataFile Instead of invoking planFiles() multiple times (once in hasDeleteFile(), and once in getIcebergDataFiles()), we could just check dataFile.content() here: https://github.com/apache/iceberg/blob/4b382e293f946fdb966e70f2f598cd5daf550651/api/src/main/java/org/apache/iceberg/DataFile.java#L100 -- To view, visit http://gerrit.cloudera.org:8080/18383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e9cbf2424b27157883d551f73e728ab4ec6d21e Gerrit-Change-Number: 18383 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Apr 2022 17:20:58 +0000 Gerrit-HasComments: Yes
