Hello Quanlong Huang, Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18385
to look at the new patch set (#7).
Change subject: IMPALA-11200: Avoid redundant "Codegen enabled" messages in
profile
......................................................................
IMPALA-11200: Avoid redundant "Codegen enabled" messages in profile
Before this patch the message was added to the profile in Open(),
which can be called multiple times in subplans.
Moved it to Close(), which is only called once in the lifetime
of a Node/Aggregator.
A drawback of this is that this info won't be visible when the
Node is still active, but I don't think that it is a very useful
info in a still running query.
Also added a new feature to test_result_verifier.py:
Inside RUNTIME_PROFILE section row_regex can be negated with !,
so !row_regex [regex] means that regex is not matched by any line
in the profile.
Testing:
- added a regression test
Change-Id: Iad2e31900ee6d29385cc8adc6bbf067d91f6450f
---
M be/src/exec/aggregator.cc
M be/src/exec/exec-node.cc
M
testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan-single-node.test
M
testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test
M tests/common/test_result_verifier.py
5 files changed, 44 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/18385/7
--
To view, visit http://gerrit.cloudera.org:8080/18385
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad2e31900ee6d29385cc8adc6bbf067d91f6450f
Gerrit-Change-Number: 18385
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
