Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18413 )
Change subject: IMPALA-11205: Implement CORR() function ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions-ir.cc@315 PS1, Line 315: void AggregateFunctions::CorrUpdate(FunctionContext* ctx, const DoubleVal& src1, const DoubleVal& src2, line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions-ir.cc@329 PS1, Line 329: void AggregateFunctions::CorrRemove(FunctionContext* ctx, const DoubleVal& src1, const DoubleVal& src2, line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions-ir.cc@346 PS1, Line 346: void AggregateFunctions::CorrMerge(FunctionContext* ctx, const StringVal& src, StringVal* dst) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions-ir.cc@361 PS1, Line 361: const StringVal AggregateFunctions::CorrSerialize(FunctionContext* ctx, const StringVal& src) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions-ir.cc@374 PS1, Line 374: double corr = ((state->prod*state->count) - (state->sumx*state->sumy)) / (pow((((state->count*state->sum_squaredx) - (state->sumx*state->sumx)) * ((state->count*state->sum_squaredy) - (state->sumy*state->sumy))), 0.5)); line too long (221 > 90) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions.h File be/src/exprs/aggregate-functions.h: http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions.h@69 PS1, Line 69: static void CorrUpdate(FunctionContext* ctx, const DoubleVal& src1, const DoubleVal& src2, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18413/1/be/src/exprs/aggregate-functions.h@71 PS1, Line 71: static void CorrRemove(FunctionContext* ctx, const DoubleVal& src1, const DoubleVal& src2, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ad627c953ba24d9cde2d5549bdd0d27a9c0d06 Gerrit-Change-Number: 18413 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Apr 2022 11:58:06 +0000 Gerrit-HasComments: Yes
