Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18403 )
Change subject: IMPALA-10839: NULL values are displayed on a wrong level for nested structs (ORC) ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Sorry for the late review. I just left one nit, other than that, I'm fine with the patch. Thanks for taking care! http://gerrit.cloudera.org:8080/#/c/18403/6/testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/18403/6/testdata/workloads/functional-query/queries/QueryTest/nested-struct-in-select-list.test@148 PS6, Line 148: select id, outer_struct from nit: I think the very first test in this file runs the same query as this one. -- To view, visit http://gerrit.cloudera.org:8080/18403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff5034e7bdf39c036aecc491fbd324e29150f040 Gerrit-Change-Number: 18403 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 08:56:46 +0000 Gerrit-HasComments: Yes
