Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18423 )
Change subject: IMPALA-11237: Preserve the behavior of concat_ws() before IMPALA-8891 ...................................................................... Patch Set 1: Thanks for the comments Csaba and Quanlong! I also prepared another patch at https://gerrit.cloudera.org/c/18440/ that uses the approach suggested by Csaba. It's not that easy to determine which approach is better. For a user that relies on Impala's old behavior, it may be easier for the user to start the Impala daemons with 'concat_ws_return_null_if_any_is_null' set to true. No change has to be made to the user's SQL scripts with respect to the behavior of CONCAT_WS(). However, it may be easier for such a user to start adapting to the new behavior of CONCAT_WS() in that no restart of Impala daemons is required. Let me know if I missed something. I think I am fine with both approaches. -- To view, visit http://gerrit.cloudera.org:8080/18423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fe11971e0c56b868bdf8bf1b071d40d9837acda Gerrit-Change-Number: 18423 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Apr 2022 04:15:13 +0000 Gerrit-HasComments: No
