Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18433 )

Change subject: IMPALA-11141: Use exact data types in IN-list filter
......................................................................


Patch Set 5:

(1 comment)

Thank Qifan for the review!

http://gerrit.cloudera.org:8080/#/c/18433/2/be/src/util/in-list-filter.cc
File be/src/util/in-list-filter.cc:

http://gerrit.cloudera.org:8080/#/c/18433/2/be/src/util/in-list-filter.cc@65
PS2, Line 65: default:
> Yes, if to preserve the precision is critical for join, then DECIMAL data t
Sure. I filed MPALA-11272 as a follow-up JIRA for this.



--
To view, visit http://gerrit.cloudera.org:8080/18433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id434a542b2ced64efa3bfc974cb565b94a4193e9
Gerrit-Change-Number: 18433
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 26 Apr 2022 23:05:13 +0000
Gerrit-HasComments: Yes

Reply via email to