Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18295 )
Change subject: IMPALA-11162: Support GenericUDFs for Hive ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/18295/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18295/8//COMMIT_MSG@26 PS8, Line 26: funciton typo http://gerrit.cloudera.org:8080/#/c/18295/7/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java: http://gerrit.cloudera.org:8080/#/c/18295/7/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java@72 PS7, Line 72: nit: 1 less line http://gerrit.cloudera.org:8080/#/c/18295/7/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java: http://gerrit.cloudera.org:8080/#/c/18295/7/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@49 PS7, Line 49: class is a copy of the TestGenericUdf class in the FE. This seems quite different at this point, e.g. members have no trailing _. Can you update from the FE version? http://gerrit.cloudera.org:8080/#/c/18295/8/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test File testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test: http://gerrit.cloudera.org:8080/#/c/18295/8/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test@254 PS8, Line 254: DATE Can you also add a test for other unsupported types, e.g. decimal and complex types? http://gerrit.cloudera.org:8080/#/c/18295/8/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test@270 PS8, Line 270: ==== Do we support variable length argument lists? Can you add a positive or negative test for that? -- To view, visit http://gerrit.cloudera.org:8080/18295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6fd09120db413fade94410c83ebe8ff104013cd Gerrit-Change-Number: 18295 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Apr 2022 17:01:29 +0000 Gerrit-HasComments: Yes
