Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18439 )
Change subject: IMPALA-11263: Coordinator hang when cancelling a query ...................................................................... Patch Set 4: (3 comments) Did code analysis for KRPC and found the root cause (see the comments in the IMPALA-11263). Will file a separate Jira to track KRPC issue. http://gerrit.cloudera.org:8080/#/c/18439/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/18439/3/be/src/runtime/coordinator-backend-state.cc@204 PS3, Line 204: if (! > That's a really good point. I missed that this while loop is now not really fixed http://gerrit.cloudera.org:8080/#/c/18439/3/be/src/runtime/coordinator-backend-state.cc@622 PS3, Line 622: l(); > nit. "Exec() rpc was not responsive after waiting for $0 ms" probably descr fixed http://gerrit.cloudera.org:8080/#/c/18439/3/be/src/runtime/coordinator-backend-state.cc@621 PS3, Line 621: cancel_exec_rpc_ = true; : exec_rpc_controller_.Cancel(); : if (!WaitOnExecLocked(&l, (int64_t)FLAGS_backend_client_rpc_timeout_ms)) { : VLogForBackend(Substitute( : "Exec() rpc was not > Just thinking this through: if this times out, then we will fall through an Right, we are not sure the state of backend if it's timeout. It's better to send cancellation RPC to backend. -- To view, visit http://gerrit.cloudera.org:8080/18439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I915511afe2df3017cbbf37f6aff3c5ff7f5473be Gerrit-Change-Number: 18439 Gerrit-PatchSet: 4 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Apr 2022 23:07:21 +0000 Gerrit-HasComments: Yes
