Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18028 )

Change subject: IMPALA-10871 (part 2): Apache Hive 3: fixes for dataset loading
......................................................................


Patch Set 7:

(2 comments)

Thanks a lot for working on this!

http://gerrit.cloudera.org:8080/#/c/18028/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18028/7//COMMIT_MSG@15
PS7, Line 15: - Manually perform data loading steps.
Are you able to run a subset of the tests? I'm curious if it's mature to add 
this into our precommit job.


http://gerrit.cloudera.org:8080/#/c/18028/7/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/18028/7/testdata/bin/generate-schema-statements.py@479
PS7, Line 479:   # For Apache Hive, "hive.hbase.bulk does not exist" exception 
will be thrown and there
             :   # is only warning in cdp
I'm curious about the exception. This feature seems already in Hive for some 
years: https://cwiki.apache.org/confluence/display/hive/hbasebulkload

Is it due to we recompile Hive?



--
To view, visit http://gerrit.cloudera.org:8080/18028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I86a1fdffc70b8d9a3bc97a72b5b939021dc496f1
Gerrit-Change-Number: 18028
Gerrit-PatchSet: 7
Gerrit-Owner: Fucun Chu <chufu...@hotmail.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 May 2022 12:34:31 +0000
Gerrit-HasComments: Yes

Reply via email to