Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )
Change subject: IMPALA-11233: Unset all query option ...................................................................... Patch Set 4: (4 comments) Thanks for taking care of this patch! It looks fine in general, I just left some minor comments. http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h@344 PS4, Line 344: Status ResetAllQueryOptions(TQueryOptions* query_options, QueryOptionsMask* mask); Could you please write some comment for this functions as you see for the others above? http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1301 PS4, Line 1301: mask nit: I see at other functions that they call this param as 'set_query_options_mask'. I find it more verbose to know the purpose. http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1307 PS4, Line 1307: query_options->__isset.NAME = defaults.__isset.NAME; \ is there a case when defaults.__isset.NAME is true? Can't we simply set query_options->__isset.NAME to false? http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java File fe/src/main/java/org/apache/impala/analysis/SetStmt.java: http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@55 PS4, Line 55: public SetStmt(boolean isUnsetAll) { At the callsite of this when you see "new SetStmt(true)" it's not really self descriptive what that true means. I'd rather use the existing constructor and set the 'isUnsetAll_' member in a next step. -- To view, visit http://gerrit.cloudera.org:8080/18430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250 Gerrit-Change-Number: 18430 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 03 May 2022 14:31:49 +0000 Gerrit-HasComments: Yes
