Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18295 )
Change subject: IMPALA-11162: Support GenericUDFs for Hive ...................................................................... Patch Set 12: (11 comments) http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java File fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java: http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/main/java/org/apache/impala/hive/executor/HiveGenericJavaFunction.java@31 PS12, Line 31: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java File fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java: http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/main/java/org/apache/impala/hive/executor/HiveUdfExecutorGeneric.java@39 PS12, Line 39: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java File fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java: http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java@32 PS12, Line 32: import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/fe/src/test/java/org/apache/impala/hive/executor/TestGenericUdf.java@33 PS12, Line 33: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java: http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java@27 PS12, Line 27: import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/GenericImportsNearbyClassesUdf.java@28 PS12, Line 28: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/GenericReplaceStringUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/GenericReplaceStringUdf.java: http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/GenericReplaceStringUdf.java@27 PS12, Line 27: import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/GenericReplaceStringUdf.java@28 PS12, Line 28: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java: http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@32 PS12, Line 32: import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector.PrimitiveCategory; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@33 PS12, Line 33: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfException.java File java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfException.java: http://gerrit.cloudera.org:8080/#/c/18295/12/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdfException.java@27 PS12, Line 27: import org.apache.hadoop.hive.serde2.objectinspector.primitive.PrimitiveObjectInspectorFactory; line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6fd09120db413fade94410c83ebe8ff104013cd Gerrit-Change-Number: 18295 Gerrit-PatchSet: 12 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 06 May 2022 17:24:37 +0000 Gerrit-HasComments: Yes
