Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18499 )
Change subject: IMPALA-11201: update gitignore files ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18499/2/.gitignore File .gitignore: http://gerrit.cloudera.org:8080/#/c/18499/2/.gitignore@4 PS2, Line 4: thirdparty > It'd be nice if this patch can remove this and fix IMPALA-11201 as well. Done and updated the patch to relate to IMPALA-11201. http://gerrit.cloudera.org:8080/#/c/18499/2/shell/.gitignore File shell/.gitignore: http://gerrit.cloudera.org:8080/#/c/18499/2/shell/.gitignore@3 PS2, Line 3: ext-py/bitarray-2.3.0/dist/ > missing "ext-py/bitarray-2.3.0/dist/build"? Turned out line 1 was matching all build directories. I've made it more precise and added `build/` for bitarray. -- To view, visit http://gerrit.cloudera.org:8080/18499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I03deba5e7fb151ef8e34039becdcc3fb47684084 Gerrit-Change-Number: 18499 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 06 May 2022 18:32:28 +0000 Gerrit-HasComments: Yes
