Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18513 )
Change subject: IMPALA-11286: Writes value_counts to Iceberg metadata ...................................................................... IMPALA-11286: Writes value_counts to Iceberg metadata Impala does not write 'value_counts' to Iceberg metadata, just 'null_value_counts'. Push-down NOT_NULL predicate does not work when the data is written by the impala, so we implement impala to write 'value_counts' to Iceberg metadata. Testing: - existing tests - tested manually on a real cluster Change-Id: I6b7afab8be197118e573fda1a381fa08e4c8c9c0 Reviewed-on: http://gerrit.cloudera.org:8080/18513 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/hdfs-table-writer.h M be/src/exec/parquet/hdfs-parquet-table-writer.cc M be/src/exec/parquet/parquet-column-stats.h M be/src/exec/parquet/parquet-column-stats.inline.h M be/src/runtime/dml-exec-state.cc M common/fbs/IcebergObjects.fbs M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-transform-insert.test M tests/query_test/test_iceberg.py 9 files changed, 35 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6b7afab8be197118e573fda1a381fa08e4c8c9c0 Gerrit-Change-Number: 18513 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
