Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18508
to look at the new patch set (#4).
Change subject: IMPALA-11275: log thread info during minidump
......................................................................
IMPALA-11275: log thread info during minidump
Writes ThreadDebugInfo to stdout/stderr when a minidump is generated to
capture thread and query details related to the dump. Example message:
> Minidump in thread [1790536]async-exec-thread running query
1a47cc1e2df94cb4:88dfa08200000000, fragment instance
0000000000000000:0000000000000000
Refactors DumpCallback so that repeated writes to STDOUT/STDERR are less
redundant.
Adds unit tests to run with ThreadDebugInfo. Removes the 'static' prefix
from DumpCallback so it can be invoked from unit tests, but doesn't add
it to the header as it's intended to be for internal use.
Testing:
- Added crash to Coordinator::Exec and manually tested dump handling.
- Added a new unit test for DumpCallback.
- Ran tests/custom_cluster/test_breakpad.py to verify nothing broke in
refactor. Those tests don't have ThreadDebugInfo available.
Change-Id: Iea2bdf10db29a0f8ccbe5e767b708781d42a9b8a
---
M be/src/util/CMakeLists.txt
M be/src/util/debug-util-test.cc
M be/src/util/debug-util.cc
M be/src/util/debug-util.h
A be/src/util/minidump-test.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
7 files changed, 190 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/18508/4
--
To view, visit http://gerrit.cloudera.org:8080/18508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea2bdf10db29a0f8ccbe5e767b708781d42a9b8a
Gerrit-Change-Number: 18508
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
