wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18023 )
Change subject: IMPALA-7942: Add query hints for cardinalities and selectivities ...................................................................... Patch Set 9: Hi Quanlong, Qifan and Zoltan, I've already modify patch to support selectivity hint for CompoundPredicate 1. We need add bracket for each predicate to use selectivity hint, such as: (a = 1) /* +SELECTIVITY(0.2)*/, (a = 1 AND b = 2) /* +SELECTIVITY(0.2)*/, bracket is necessary due to CompoundPredicate supporting; 2. This syntax is allowed: ((a = 1) /* +SELECTIVITY(0.2)*/) /* +SELECTIVITY(0.3)*/, and the outer selectivity will override inner selectivity; 3. FE planner will keep 'AND' CompoundPredicate as a conjunct when setting selectivity hint, instead of split to two BinaryPredicate. I will modify test cases and commit msg after we discuss this adjust. Hope for your advice. -- To view, visit http://gerrit.cloudera.org:8080/18023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2776b9bbd878b8a21d9c866b400140a454f59e1b Gerrit-Change-Number: 18023 Gerrit-PatchSet: 9 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Fri, 13 May 2022 08:48:27 +0000 Gerrit-HasComments: No
