Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18458 )
Change subject: IMPALA-11274: CNF Rewrite causes a regress in join node performance ...................................................................... Patch Set 8: (2 comments) I'm working on updating this patch. http://gerrit.cloudera.org:8080/#/c/18458/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18458/3//COMMIT_MSG@32 PS3, Line 32: 2. Core tests; > Definitely need to check that the transform is still applied in improved ca https://github.com/apache/impala/blob/master/testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q13.test was originally added for that ticket and is unchanged by this patch. http://gerrit.cloudera.org:8080/#/c/18458/7/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/18458/7/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@605 PS7, Line 605: public void TestFeasibleToConvertToCNF() { > I added two more tests on AND and OR but was not able to test it out as my TestFeasibleToConvertToCNF passes. I'd appreciate thoughts on examples for convert-to-cnf.test. -- To view, visit http://gerrit.cloudera.org:8080/18458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I326406c6b004fe31ec0e2a2f390a3845b8925aa9 Gerrit-Change-Number: 18458 Gerrit-PatchSet: 8 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 13 May 2022 17:46:55 +0000 Gerrit-HasComments: Yes
