Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18533 )
Change subject: IMPALA-11295: deflake TestParquet.test_multiple_blocks_mt_dop ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18533/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18533/1/tests/query_test/test_scanners.py@a698 PS1, Line 698: > Was this an invalid assumption, or did it change at some point? Good question. I think it's an invalid assumption but I'm not pretty sure about this. I'll look into more details about this. http://gerrit.cloudera.org:8080/#/c/18533/1/tests/query_test/test_scanners.py@699 PS1, Line 699: # Again skip the Averaged Fragment; it comes first in the runtime profile. > If ranges_complete_list starts with an Averaged Fragment, it's not clear to Sorry that I should have added more comments. The host list is extracted for each fragment instance. There are 7 instances. The first one is the coordinator fragment instance which doesn't have the ScanRangesComplete counter, so we can skip it. The other 6 instances are all the scan fragment. The profile is attached at https://issues.apache.org/jira/secure/attachment/13043781/test_multiple_blocks_mt_dop.profile.txt Added more comments in the next patch set. -- To view, visit http://gerrit.cloudera.org:8080/18533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16c576c41a212f83dda82a83931ab336a78a41e4 Gerrit-Change-Number: 18533 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 18 May 2022 02:12:23 +0000 Gerrit-HasComments: Yes
