Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 )
Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/16909/15/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: http://gerrit.cloudera.org:8080/#/c/16909/15/be/src/exprs/anyval-util.h@312 PS15, Line 312: FindUtf8PosForward(reinterpret_cast<const char*>(slot), type.len * 4, type.len) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/16909/15/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/16909/15/be/src/runtime/raw-value.cc@84 PS15, Line 84: int str_len = type.is_utf8 ? FindUtf8PosForward(chars, type.len * 4, type.len) : type.len; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/16909/15/be/src/runtime/raw-value.cc@123 PS15, Line 123: int str_len = type.is_utf8 ? FindUtf8PosForward(chars, type.len * 4, type.len) : type.len; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/16909/15/be/src/runtime/raw-value.cc@363 PS15, Line 363: int str_len = type.is_utf8 ? FindUtf8PosForward(chars, type.len * 4, type.len) : type.len; line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/16909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62efa3042c64d1d005a2cf4fd1d31e992543963f Gerrit-Change-Number: 16909 Gerrit-PatchSet: 15 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 19 May 2022 05:49:04 +0000 Gerrit-HasComments: Yes
