Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18369 )
Change subject: IMPALA-11129: Support running KRPC over Unix Domain Socket ...................................................................... Patch Set 8: (5 comments) Joe, thanks for your feedback. http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/rpc/rpc-mgr-test.cc@380 PS8, Line 380: // Run tests with Unix domain socket. : FLAGS_rpc_use_unix_domain_socket = true; : discard_result(RUN_ALL_TESTS()); : // Run tests with TCP socket. : FLAGS_rpc_use_unix_domain_socket = false; : return RUN_ALL_TESTS(); > Couple thoughts: Will fix it by using INSTANTIATE_TEST_CASE_P in gtest. http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/rpc/rpc-mgr.cc@120 PS8, Line 120: else { : uds_addr_unique_id_ = UdsAddressUniqueIdPB::IP_ADDRESS; : } > It would be good to match "ip_address" and produce an error if usd_address_ Should we stop running if usd_address_unique_id is not one of allowed values? http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/runtime/exec-env.cc@273 PS8, Line 273: // TODO: get BackendId of admissiond. Use a fixed UUID now. : admissiond_backend_id.set_hi(12345678); : admissiond_backend_id.set_lo(87654321); > Will this be addressed in a separate JIRA? I am not sure if we should support to use backend_id as unique id for UDS. But I saw Kudu to use UUID as unique id for UDS. If we decide to support it, I will address it in a separate JIRA. http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/18369/8/be/src/util/network-util.cc@198 PS8, Line 198: NetworkAddressPB MakeNetworkAddressPB(const std::string& hostname, int port, : const UniqueIdPB& backend_id, const UdsAddressUniqueIdPB& uds_addr_unique_id) { > Would it be useful to have a wrapper function that generates its own random Good suggestion. Will do. http://gerrit.cloudera.org:8080/#/c/18369/8/common/protobuf/common.proto File common/protobuf/common.proto: http://gerrit.cloudera.org:8080/#/c/18369/8/common/protobuf/common.proto@28 PS8, Line 28: // Unix Domain Socket address. We use the unique name in "Abstract Namespace" as UDS : // address in the form of "@impala-krpc:<unique-id>". This field is optional. : // It is only used for KRPC bind/listen/connect when FLAGS_rpc_use_unix_domain_socket : // is set as true. : optional string uds_address = 3; > Should we have a symmetric change in TNetworkAddress? The locations doing F We only support UDS for KPRC, not for thrift RPC. I think TNetworkAddress don't need to know about UDS. -- To view, visit http://gerrit.cloudera.org:8080/18369 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I439f5a03eb425c17451bcaa96a154bb0bca17ee7 Gerrit-Change-Number: 18369 Gerrit-PatchSet: 8 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 20 May 2022 01:18:32 +0000 Gerrit-HasComments: Yes
