Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18560
Change subject: IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package ...................................................................... IMPALA-11313: Use Thrift 0.14.2 for impala-shell PyPi package Thrift 0.11.0 has known issues where Unicode errors are not handler properly, including one case where the client can hang. The traditional form factor for impala-shell uses a patched Thrift that fixes those issues, but the PyPi package uses the unpatched Thrift 0.11.0. This modifies the requirements.txt file to use Thrift 0.14.2, which has fixes for these Unicode issues. Thrift 0.14.2 has a slightly different error message, so this amends the allowed error messages in test_utf8_decoding_error_handling(). This is a bit awkward, given that the Python code generation continues to happen with Thrift 0.11.0. Comparing the Python code for Thrift 0.11 vs Thrift 0.14, I didn't see noticeable differences. Given that the client can hang, this seems worth fixing ahead of the full conversion to Thrift 0.14 for all of Impala. Testing: - Ran the Unicode error handling tests with a PyPi impala-shell - Ran the shell tests normally Change-Id: I63e0a5dda98df20c9184a347397118b1f3529603 (cherry picked from commit 468a26fdd8687e11d2e4b61946a84b5d8fef4e48) --- M shell/packaging/requirements.txt M tests/shell/test_shell_commandline.py 2 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/18560/1 -- To view, visit http://gerrit.cloudera.org:8080/18560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I63e0a5dda98df20c9184a347397118b1f3529603 Gerrit-Change-Number: 18560 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
