Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18397 )
Change subject: IMPALA-9410: Support resolving ORC file columns by names ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18397/6/be/src/exec/orc-metadata-utils.h File be/src/exec/orc-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/18397/6/be/src/exec/orc-metadata-utils.h@109 PS6, Line 109: std::string > This is still unresolved. Done http://gerrit.cloudera.org:8080/#/c/18397/6/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/18397/6/be/src/exec/orc-metadata-utils.cc@247 PS6, Line 247: std::string > could be const& Done -- To view, visit http://gerrit.cloudera.org:8080/18397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29562a059160c19eb58ccea76aa959d2e408f8de Gerrit-Change-Number: 18397 Gerrit-PatchSet: 6 Gerrit-Owner: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 13:37:50 +0000 Gerrit-HasComments: Yes
