Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18576 )
Change subject: IMPALA-11325: Fix UnicodeDecodeError for shell file output ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18576/2/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/18576/2/shell/shell_output.py@120 PS2, Line 120: if sys.version_info.major == 2: > Can we add a predicate for isinstance(formatted_data, str)? Then in Python Good point, I added that and verified that the tests still pass. -- To view, visit http://gerrit.cloudera.org:8080/18576 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic40be3d530c2694465f7bd2edb0e0586ff0e1fba Gerrit-Change-Number: 18576 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 01 Jun 2022 19:18:12 +0000 Gerrit-HasComments: Yes
