Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18549 )
Change subject: IMPALA-1682: Support printing the output of a query (rows) vertically. ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/18549/5/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/18549/5/shell/shell_output.py@108 PS5, Line 108: val in row] > It seems that I should use "from shell.impala_client import utf8_encode_if_ Sorry that I think we can leave it as-is, because using utf8_encode_if_needed() will check the major version inside the loop, which is slightly inefficient than this. http://gerrit.cloudera.org:8080/#/c/18549/5/shell/shell_output.py@110 PS5, Line 110: ow *********************************** > the width in mysql is also fixed: https://github.com/mysql/mysql-server/blo Sure. Thanks for sharing the MySQL codes. http://gerrit.cloudera.org:8080/#/c/18549/7/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/18549/7/shell/shell_output.py@85 PS7, Line 85: row = [val.encode('utf-8', 'replace') if isinstance(val, unicode) else val Python3 doesn't have 'unicode' type. We should still check sys.version_info.major here. We only need this encoding in Python2. http://gerrit.cloudera.org:8080/#/c/18549/5/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/18549/5/tests/shell/test_shell_commandline.py@295 PS5, Line 295: select 1 as > Done I see you use c1, c2, c3 as the column names. I tend to names in different size so we can test the alignment of colon. -- To view, visit http://gerrit.cloudera.org:8080/18549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cee48d5a239d6b7c0f51331275524a25130fadf Gerrit-Change-Number: 18549 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward <yx91...@126.com> Gerrit-Reviewer: Anonymous Coward <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 06 Jun 2022 07:45:21 +0000 Gerrit-HasComments: Yes