Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17781 )
Change subject: IMPALA-10865: Fix initialize SelectStmt's groupingExprs_ in analyzeGroupingExprs ...................................................................... Patch Set 7: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/17781/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17781/7//COMMIT_MSG@11 PS7, Line 11: But the following IMPALA-9693 explicit analyze nit: But the following patch of IMPALA-9693 explicitly analyzes http://gerrit.cloudera.org:8080/#/c/17781/7//COMMIT_MSG@17 PS7, Line 17: rewrite rules should keep rewritted : exprs are analyzed nit: reword to "rewrite rules should ensure rewritten exprs are analyzed" http://gerrit.cloudera.org:8080/#/c/17781/7//COMMIT_MSG@31 PS7, Line 31: modify nit: modifies http://gerrit.cloudera.org:8080/#/c/17781/7//COMMIT_MSG@32 PS7, Line 32: rewritted nit: rewritted -> rewritten http://gerrit.cloudera.org:8080/#/c/17781/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test File testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test: http://gerrit.cloudera.org:8080/#/c/17781/7/testdata/workloads/functional-planner/queries/PlannerTest/aggregation.test@1677 PS7, Line 1677: explain We don't need EXPLAIN here. The queries in PlannerTest are not actually executed. We just get the exec request and verify the plans: https://github.com/apache/impala/blob/9baf790606073d88c3a2fd431110812140df0cb7/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java#L519-L520 -- To view, visit http://gerrit.cloudera.org:8080/17781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d1779e6c282d9fd02beacf5ddfafcc5c0baf3b0 Gerrit-Change-Number: 17781 Gerrit-PatchSet: 7 Gerrit-Owner: guojingfeng <guojingf...@tencent.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: guojingfeng <guojingf...@tencent.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Mon, 06 Jun 2022 08:11:44 +0000 Gerrit-HasComments: Yes