Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18565 )
Change subject: IMPALA-5845: Limit the number of non-fatal errors logging to INFO ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/18565/5/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: http://gerrit.cloudera.org:8080/#/c/18565/5/be/src/runtime/runtime-state.cc@205 PS5, Line 205: VLOG(vlog_level) << "Error from query " << PrintId(query_id()) << ": " << message.msg(); > I add VLOG_IS_ON check in patch set 6. We can defer this for now. I was thinking about cases where the whole job is erroring out that could be impacted more. I prototyped some small changes that allow for easy migration and they are fairly small. -- To view, visit http://gerrit.cloudera.org:8080/18565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I924768ec461735c172fbf75d6415033bbdb77f9b Gerrit-Change-Number: 18565 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Jun 2022 16:26:38 +0000 Gerrit-HasComments: Yes