Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 )
Change subject: IMPALA-11284: Enable expression rewrites for || and Between predicate in values clause ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18581/3/fe/src/main/java/org/apache/impala/analysis/ValuesStmt.java File fe/src/main/java/org/apache/impala/analysis/ValuesStmt.java: http://gerrit.cloudera.org:8080/#/c/18581/3/fe/src/main/java/org/apache/impala/analysis/ValuesStmt.java@95 PS3, Line 95: > nit: extra line Done http://gerrit.cloudera.org:8080/#/c/18581/3/testdata/workloads/functional-query/queries/QueryTest/values.test File testdata/workloads/functional-query/queries/QueryTest/values.test: http://gerrit.cloudera.org:8080/#/c/18581/3/testdata/workloads/functional-query/queries/QueryTest/values.test@149 PS3, Line 149: "hello" || "world", 0 <= 1 || 0.5 < 0.6 > Can you also add a test with a || and between are not the root expressions, Yeah looks like we are not handling this if the said operators are deeper in the expression tree. I will upload a new patch with the fix. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99b8b33bf6468d12b9e26f0a6e744feb7072619c Gerrit-Change-Number: 18581 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Jun 2022 19:11:34 +0000 Gerrit-HasComments: Yes
