Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18596 )
Change subject: IMPALA-9496: Allow struct type in the select list for Parquet tables ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18596/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18596/3//COMMIT_MSG@23 PS3, Line 23: ple ReadValue() on these readers instead of the : batched version. The reason is that calling the batched reader in : the member column readers would in fact read in batches, but it : won't handle the case when the parent struct i > Well I'm not completely in favor of the proposed approach. It would be comp Ok, we can think about optimizations later. -- To view, visit http://gerrit.cloudera.org:8080/18596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e8b4cbc2c4d1dd5fbefb7c87dad8d4e6ac2f452 Gerrit-Change-Number: 18596 Gerrit-PatchSet: 5 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Jun 2022 11:16:56 +0000 Gerrit-HasComments: Yes
