Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18629 )
Change subject: IMPALA-11365: Dereferencing null pointer in TopNNode ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18629/1/be/src/exec/topn-node.cc File be/src/exec/topn-node.cc: http://gerrit.cloudera.org:8080/#/c/18629/1/be/src/exec/topn-node.cc@132 PS1, Line 132: dummy_scalar_exprs_ We are passing an uninitialized object here. When the ctor of the base class is invoked, the members of this class are not initialized yet. Maybe we could make the dummy fields static? http://gerrit.cloudera.org:8080/#/c/18629/1/be/src/exec/topn-node.cc@139 PS1, Line 139: return std::less<const TupleRow*>{}(lhs, rhs); Should this be ever invoked? If not, we could add a DCHECK(false). -- To view, visit http://gerrit.cloudera.org:8080/18629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0b15b06f608b4d17fdf8a24e05967aaa16ebb79c Gerrit-Change-Number: 18629 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 17 Jun 2022 12:41:01 +0000 Gerrit-HasComments: Yes
