Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18616 to look at the new patch set (#3). Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs ...................................................................... IMPALA-10545: Higher data_cache_write_concurrency for SSDs Provide device-specific defaults for `data_cache_write_concurrency` based on device type. Rotational disks continue to use a default of 1, while non-rotational disks use a default of 8. Option default of 0 is used to select this mode. Added unit test confirming concurrency based on mocked partitions and block device info. Replaced FRIEND_TEST macros for a test that no longer exists. Started cluster with start-impala-cluster.py --data_cache_dir=/home/michael/cache --data_cache_size=1G --impalad_args=--always_use_data_cache=true and observed > Default data_cache_write_concurrency=8 for non-rotational disk nvme0n1 Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609 --- M be/src/runtime/io/data-cache-test.cc M be/src/runtime/io/data-cache.cc M be/src/runtime/io/data-cache.h M be/src/util/disk-info.cc M be/src/util/disk-info.h 5 files changed, 126 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/18616/3 -- To view, visit http://gerrit.cloudera.org:8080/18616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609 Gerrit-Change-Number: 18616 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>