Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18688 )
Change subject: IMPALA-11362: Add expire snapshots functionality for Iceberg tables ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/18688/1/tests/common/iceberg_test_suite.py File tests/common/iceberg_test_suite.py: http://gerrit.cloudera.org:8080/#/c/18688/1/tests/common/iceberg_test_suite.py@20 PS1, Line 20: from tests.common.impala_test_suite import ImpalaTestSuite, LOG flake8: F401 'tests.common.impala_test_suite.LOG' imported but unused http://gerrit.cloudera.org:8080/#/c/18688/1/tests/common/iceberg_test_suite.py@22 PS1, Line 22: class IcebergTestSuite(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18688/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18688/1/tests/query_test/test_iceberg.py@37 PS1, Line 37: class TestIcebergTable(IcebergTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/18688/1/tests/query_test/test_iceberg.py@90 PS1, Line 90: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/18688/1/tests/query_test/test_iceberg.py@90 PS1, Line 90: self.execute_query_ts(impalad_client, expire_q.format(tbl_name, line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/18688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ideffee4964c18c85ca745bfb4eca08ec362416f3 Gerrit-Change-Number: 18688 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Jul 2022 07:15:31 +0000 Gerrit-HasComments: Yes
