Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )
Change subject: IMPALA-11344: Missing slots in all cases should be allowed to be read ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/18652/12/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18652/12/tests/query_test/test_scanners.py@1779 PS12, Line 1779: assert result.data == ['NULL'] It's unclear to me why the result is just one row of 'NULL'. Shouldn't the result be [1, 'NULL'] (in random order)? Note that at line 1776 we insert the second row. -- To view, visit http://gerrit.cloudera.org:8080/18652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023 Gerrit-Change-Number: 18652 Gerrit-PatchSet: 12 Gerrit-Owner: ttttttz <2433038...@qq.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: ttttttz <2433038...@qq.com> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:56:44 +0000 Gerrit-HasComments: Yes
