Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18526 )
Change subject: IMPALA-10851: Codegen for structs ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/codegen/codegen-anyval-read-write-info.cc File be/src/codegen/codegen-anyval-read-write-info.cc: http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/codegen/codegen-anyval-read-write-info.cc@83 PS8, Line 83: void CodegenAnyValReadWriteInfo::SetTimeAndDate(llvm::Value* time_of_day, llvm::Value* date) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/codegen/codegen-anyval.h File be/src/codegen/codegen-anyval.h: http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/codegen/codegen-anyval.h@246 PS8, Line 246: static CodegenAnyVal CreateFromReadWriteInfo(const CodegenAnyValReadWriteInfo& read_write_info); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/codegen/codegen-anyval.cc@1022 PS8, Line 1022: void CodegenAnyVal::StructChildToReadWriteInfo(CodegenAnyValReadWriteInfo* read_write_info, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/exec/hash-table.cc@792 PS8, Line 792: void HashTableCtx::CodegenConvertToCanonicalForm(CodegenAnyValReadWriteInfo* read_write_info) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18526/8/be/src/exec/hash-table.cc@809 PS8, Line 809: void HashTableCtx::CodegenConvertToCanonicalForm(LlvmBuilder* builder, CodegenAnyVal* anyval) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18526/8/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18526/8/tests/query_test/test_nested_types.py@143 PS8, Line 143: , flake8: E231 missing whitespace after ',' -- To view, visit http://gerrit.cloudera.org:8080/18526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5272c3f095fd9f07877104ee03c8e43d0c4ec0b6 Gerrit-Change-Number: 18526 Gerrit-PatchSet: 8 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Jul 2022 14:26:41 +0000 Gerrit-HasComments: Yes
