Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18704 )
Change subject: IMPALA-11350: Add virtual column FILE__POSITION for Parquet tables ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/18704/3/be/src/exec/parquet/parquet-collection-column-reader.cc File be/src/exec/parquet/parquet-collection-column-reader.cc: http://gerrit.cloudera.org:8080/#/c/18704/3/be/src/exec/parquet/parquet-collection-column-reader.cc@84 PS3, Line 84: pos_slot_desc() ? tuple->GetBigIntSlot(pos_slot_desc()->tuple_offset()) : nullptr, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18704/3/be/src/exec/parquet/parquet-collection-column-reader.cc@85 PS3, Line 85: file_pos_slot_desc() ? tuple->GetBigIntSlot(file_pos_slot_desc()->tuple_offset()) : nullptr); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/18704/3/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18704/3/be/src/exec/parquet/parquet-column-readers.cc@1059 PS3, Line 1059: const parquet::ColumnChunk& col_chunk, int row_group_idx, int64_t row_group_first_row) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18704/3/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18704/3/tests/query_test/test_scanners.py@142 PS3, Line 142: I flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/18704/3/tests/query_test/test_scanners.py@428 PS3, Line 428: l flake8: E126 continuation line over-indented for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/18704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ef72c683d0d5ae2898bca36fa87e74b663671f7 Gerrit-Change-Number: 18704 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <gfurnst...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Jul 2022 15:50:20 +0000 Gerrit-HasComments: Yes
