Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18718 )
Change subject: IMPALA-11355: Add STRING overloads for hour/minute/second/millisecond ...................................................................... Patch Set 2: (3 comments) Thanks Csaba for working on this. I have few comments. http://gerrit.cloudera.org:8080/#/c/18718/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18718/2//COMMIT_MSG@24 PS2, Line 24: note ni: not http://gerrit.cloudera.org:8080/#/c/18718/2//COMMIT_MSG@26 PS2, Line 26: Testing: Do you mind adding this new case in expr-benchmark.cc as well? In BenchmarkTimestampFunctions. Maybe also update the benchmark result table as well just for BenchmarkTimestampFunctions. http://gerrit.cloudera.org:8080/#/c/18718/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/18718/2/be/src/exprs/expr-test.cc@6957 PS2, Line 6957: // These expressions directly extract hour/minute/second/millis from STRING type : // to support these functions for timestamp strings without a date part (IMPALA-11355). What is the expected result of "SELECT HOUR("838:59:59");"? Can we also have invalid case where: - Minutes and seconds is more than 59 - Has "am" or "pm" behind time. -- To view, visit http://gerrit.cloudera.org:8080/18718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cc1c851ee71ab4fcc58105c7e9931155a483679 Gerrit-Change-Number: 18718 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Jul 2022 17:40:47 +0000 Gerrit-HasComments: Yes
