Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18718 )
Change subject: IMPALA-11355: Add STRING overloads for hour/minute/second/millisecond ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/18718/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18718/2//COMMIT_MSG@24 PS2, Line 24: not > Done Thank you. http://gerrit.cloudera.org:8080/#/c/18718/2//COMMIT_MSG@26 PS2, Line 26: Testing: > added tests and fixed the old ones - note that my machine seems much slower Thank you. http://gerrit.cloudera.org:8080/#/c/18718/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/18718/2/be/src/exprs/expr-test.cc@6957 PS2, Line 6957: // These expressions directly extract hour/minute/second/millis from STRING type : // to support these functions for timestamp strings without a date part (IMPALA-11355). > Done Thank you. http://gerrit.cloudera.org:8080/#/c/18718/5/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/18718/5/be/src/exprs/expr-test.cc@6967 PS5, Line 6967: TestIsNull("minute('838:59:59')", TYPE_INT); Should it be "hour('838:59:59')"? MySQL's hour function seems to accept string where the hour part is more than 23. https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_hour Not sure if its standard though. -- To view, visit http://gerrit.cloudera.org:8080/18718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cc1c851ee71ab4fcc58105c7e9931155a483679 Gerrit-Change-Number: 18718 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Jul 2022 18:50:44 +0000 Gerrit-HasComments: Yes
