Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18676 )
Change subject: IMPALA-11430: Support custom hash schema for Kudu range tables ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/18676/17/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test File testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test: http://gerrit.cloudera.org:8080/#/c/18676/17/testdata/workloads/functional-query/queries/QueryTest/kudu_partition_ddl.test@322 PS17, Line 322: ---- QUERY > Does it make sense to add a test case to add a range into a table with non- Or in that case we expect that the range would have the table-wide hash schema to preserve backwards compatibility and keep it inline with the POLA? Anyways, I guess it makes sense to add a test case for that to be explicit about what should be the expected behavior. -- To view, visit http://gerrit.cloudera.org:8080/18676 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I981056e0827f4957580706d6e73742e4e6743c1c Gerrit-Change-Number: 18676 Gerrit-PatchSet: 17 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 16 Jul 2022 01:58:02 +0000 Gerrit-HasComments: Yes
