Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18792 )
Change subject: IMPALA-11457 Fix regression with unknown disk id ...................................................................... Patch Set 1: Code-Review+2 > Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > > Patch Set 1: > > > > > > > > > Patch Set 1: > > > > > > > > > > Nice finding! Can we reveal the bug using existing test data? Or does > > > > > it only happen on Ozone? > > > > > > > > I don't know of a case with HDFS where the storage ID is unknown. Maybe? > > > > > > I think cloud storages like S3 will have unknown disk id as -1. But now > > > sure if we actually use it. > > > > > > If this can't be revealed by existing test data, maybe it won't worth a > > > separated patch and we can merge it with the ozone patch. > > > > That's fair, I can't think of any way this would show up outside of Ozone. > > The main implication seems to be that local reads don't get assigned > > individual read queues, and we only get into that scenario with Ozone. > > I'm tempted to leave it separate though because Ozone is usable in Impala > already, so this is an issue customers could run into. The other ticket is > all internal dev/test work. Ah, that makes sense. It seems that we can't add tests due to missing Ozone in the test cluster. I'm ok to merge this without tests. -- To view, visit http://gerrit.cloudera.org:8080/18792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I571ac0669ceb6a42561594c3f96723d5ed293902 Gerrit-Change-Number: 18792 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 29 Jul 2022 01:12:29 +0000 Gerrit-HasComments: No
