Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )
Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java: http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@223 PS7, Line 223: + " cannot be cloned because it cannot be cloned into a " > It'd be better to mention the original table type. Maybe we can reword this I also think it'd be better to mention the original table type, but I didn't find the proper way to get the original table type from FeTable. http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3786 PS7, Line 3786: extractCreateTableParams > nit: This only works for kudu tables so "extractKuduCreateTableParams" migh Done http://gerrit.cloudera.org:8080/#/c/18729/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3802 PS7, Line 3802: hava > typo? "having range partitions" ? Done http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/datasets/functional/functional_schema_template.sql File testdata/datasets/functional/functional_schema_template.sql: http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/datasets/functional/functional_schema_template.sql@266 PS7, Line 266: PARTITION BY HASH (id) PARTITIONS 3 STORED AS KUDU; > It's an existing bug that we missed the comment here. Could you fix this to Done http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test: http://gerrit.cloudera.org:8080/#/c/18729/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test@96 PS7, Line 96: hava > typo? Done -- To view, visit http://gerrit.cloudera.org:8080/18729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42 Gerrit-Change-Number: 18729 Gerrit-PatchSet: 7 Gerrit-Owner: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiaoqing Gao <gaoxq...@gmail.com> Gerrit-Comment-Date: Fri, 29 Jul 2022 07:58:03 +0000 Gerrit-HasComments: Yes
